Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use network:app:appID:pubKey for subject #106

Merged
merged 27 commits into from
May 15, 2024
Merged

use network:app:appID:pubKey for subject #106

merged 27 commits into from
May 15, 2024

Conversation

joe-p
Copy link
Collaborator

@joe-p joe-p commented Apr 22, 2024

Description

Please explain the changes you made.

  • Adds the network to the subject (for example did:algo:testnet:app:654583141:7d42e6e0f3c71d777de36849cf96e28b812453198cee2d2cc2b7b19438060007)

Checklist

  • Update internal methods to use network
  • Test all functions in TUTORIAL.md with CLI
  • Test resolver
  • Update config and CLI to handle multiple networks
  • Test multiple networks with CLI and resolver
  • Update README/TUTORIAL

@HashMapsData2Value
Copy link

Does pub key refer to the genesis hash?

@HashMapsData2Value
Copy link

I see that we are testing against 3 different versions of Go (1.19, 1.20, 1.21), resulting in triple the comments in terms of linting etc. Is this necessary?

@joe-p
Copy link
Collaborator Author

joe-p commented Apr 24, 2024

Does pub key refer to the genesis hash?

No pubkey here is the ed25519 pubkey for the subject. The network is mainnet or testnet. Internally the genesis hash is used to make sure the algod being used is the correct genesis hash.

I see that we are testing against 3 different versions of Go (1.19, 1.20, 1.21), resulting in triple the comments in terms of linting etc. Is this necessary?

Probably not. I think because the main form of distribution is docker we can probably just pick one and stick with it.

@joe-p joe-p changed the title use network-pubkey-appid for suject use network:namespace:pubkey:appID for suject Apr 30, 2024
@joe-p joe-p changed the title use network:namespace:pubkey:appID for suject use network:namespace:pubkey:appID for subject Apr 30, 2024
@joe-p joe-p changed the title use network:namespace:pubkey:appID for subject use network:app:appID:pubKey for subject May 8, 2024
@joe-p
Copy link
Collaborator Author

joe-p commented May 8, 2024

I have started to work on the spec to make sure we're all on the same page on the formatting. Once we're all good, I will update the code to reflect the spec.

@joe-p
Copy link
Collaborator Author

joe-p commented May 13, 2024

I've implemented the new spec

Manually verified omitted networks work with command ./algoid resolve did:algo:app:1845671812:da490f2d15a625459bf970a3d55e1a646dfd3a956d011546e953e945d39fdada

@joe-p joe-p marked this pull request as ready for review May 13, 2024 18:40
@joe-p joe-p requested a review from ehanoc May 13, 2024 18:41
@joe-p joe-p mentioned this pull request May 13, 2024
@joe-p joe-p merged commit 80da1db into main May 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants